Update 5.3.x to current dependencies and support Java 11 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed Gradle to 1.12 - Change antlr-runtime to 3.5.2 - Use Firefox 24 ESR - Remove the opera* launch commands
- Gradle 4 migration - Fix dependencies (junit still used) - Fix test for JDK 8 (hashCode) - switch to OpenJDK 8
- remove antlr from dependencies, see gradle/gradle#820 - remove duplicate Jetty dependency
|
@thiagohp maybe you can have a look at that - thanks! |
|
Strange the same build just worked in my repo: https://github.com/derkoe/tapestry-5/runs/1231050611 |
Update some more versions, use variables
|
Why don't you use a newer version ? |
|
@martin-g because 5.4 was a big release with many breaking changes which makes updates of bigger applications nearly impossible. It should have been called Tapestry 6. |
|
Hello, @derkoe ! Is this pull request still relevant? I apologize for only looking at it now. Cheers! |
|
@thiagohp yes that is still relevant - but now it should be Java 17. I will update the PR |
* Add build for all pull requests on GitHub * Add matrix for all supported Java versions (cherry picked from commit 9d8de2f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates most dependencies to recent versions and makes Tapestry 5.3.x run in Java 11.
We have tested this with a big Tapestry application and it all seems to work quite well.
Would be great to see a 5.3.9 with Java 11 support.