#2058 moved unit measurement definitions to backend #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
| } | ||
| } | ||
|
|
||
| return gson.toJson(unitDescriptionList); |
There was a problem hiding this comment.
Do you know if there is a reason why we return a serialized string instead of a List<UnitDescription>?
Then the REST API could serialize the result value automatically.
There was a problem hiding this comment.
I'm not sure, the other units endpoint is implemented like that. Would you like me to remove manual serialization for this one?
There was a problem hiding this comment.
Thanks, this would be great!
|
@IsaakKrut great that you found this and thanks for the PR. |
dominikriemer
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #2058
Remarks
I compared the contents of the unit-provider.service.ts and what already exists in the backend and the lists of Unit Descriptions were identical
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no