Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix python client Flake8 errors #2883

Merged
merged 3 commits into from
May 23, 2024
Merged

fix: Fix python client Flake8 errors #2883

merged 3 commits into from
May 23, 2024

Conversation

ittuann
Copy link
Contributor

@ittuann ittuann commented May 21, 2024

Purpose

tests/client/test_client.py:141:121: E501 line too long (134 > 120 characters)

This issue also causes pre-commit checks to fail.

Remarks

PR introduces (a) breaking change(s): <yes/no>
no
PR introduces (a) deprecation(s): <yes/no>
no

@github-actions github-actions bot added python Pull requests that update Python code testing Relates to any kind of test (unit test, integration, or E2E test). labels May 21, 2024
@bossenti
Copy link
Contributor

It looks like the tests directory is not included in the lint make command.
Can you adjust this as well?

@ittuann
Copy link
Contributor Author

ittuann commented May 23, 2024

It looks like the tests directory is not included in the lint make command. Can you adjust this as well?

Certainly, thanks for pointing that out! I've adjusted the lint command.

@bossenti bossenti merged commit 5cd43d5 into apache:dev May 23, 2024
21 checks passed
@ittuann ittuann deleted the flake8 branch May 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants