[SPARK-50990][SQL] Refactor UpCast resolution out of the Analyzer
#49669
+73
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, LGTM. Merging to master/4.0. |
MaxGekk
pushed a commit
that referenced
this pull request
Jan 26, 2025
### What changes were proposed in this pull request? Refactor `UpCast` resolution out of the `Analyzer`. ### Why are the changes needed? To reuse this code in single-pass `Resolver`. ### Does this PR introduce _any_ user-facing change? No, just a refactoring. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? Copilot.nvim. Closes #49669 from vladimirg-db/vladimirg-db/refactor-upcast-resolution-out. Authored-by: Vladimir Golubev <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit d0b1b0b) Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
UpCastresolution out of theAnalyzer.Why are the changes needed?
To reuse this code in single-pass
Resolver.Does this PR introduce any user-facing change?
No, just a refactoring.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
Copilot.nvim.