Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish 3.5.4 to docker registry #77

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Publish 3.5.4 to docker registry #77

merged 4 commits into from
Dec 22, 2024

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Dec 20, 2024 •
edited
Loading

What changes were proposed in this pull request?

Publish 3.5.4 to docker registry

Why are the changes needed?

3.5.4 release step

Does this PR introduce any user-facing change?

no

How was this patch tested?

CI

@LuciferYang LuciferYang marked this pull request as draft December 20, 2024 12:12
@LuciferYang
Copy link
Contributor Author

will re-triggered after the tar package is released

dongjoon-hyun
dongjoon-hyun reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you retry, @LuciferYang ?

@LuciferYang
Copy link
Contributor Author

image

still

132.9 failed: Connection timed out.
132.9 failed: Network is unreachable.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Dec 20, 2024
Merged
@dongjoon-hyun
Copy link
Member

It seems that ASF Download to ASF Archive sync needs a little more time.

@dongjoon-hyun
Copy link
Member

BTW, ASF Archive is ready now. Could you re-trigger once more?

https://archive.apache.org/dist/spark/spark-3.5.4/

Screenshot 2024-12-20 at 09 05 40

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 20, 2024 •
edited
Loading

It's working now. And, I re-triggered.

$ curl -LO https://archive.apache.org/dist/spark/spark-3.5.4/spark-3.5.4-bin-hadoop3.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  382M  100  382M    0     0  12.9M      0  0:00:29  0:00:29 --:--:-- 12.0M

@LuciferYang LuciferYang marked this pull request as ready for review December 20, 2024 17:10
@LuciferYang
Copy link
Contributor Author

image

Maybe it's the same issue as apache/spark#48406 ？

LuciferYang
LuciferYang commented Dec 20, 2024
View reviewed changes
.github/workflows/main.yml Outdated
@@ -257,6 +257,11 @@ jobs:
path: ~/.cache/coursier
key: build-${{ inputs.spark }}-scala${{ inputs.scala }}-java${{ inputs.java }}-coursier

- name: Install R
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be done in a preceding pr but let me try it out first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun It seems that we need to manually install the R environment for ubuntu-latest, after the installation, the tests for 3.5.4 all seem to have succeeded.

Before

https://github.com/apache/spark-docker/actions/runs/12431196505/job/34721415046

After

https://github.com/apache/spark-docker/actions/runs/12436092928/job/34723236153?pr=77

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun

Is this solution acceptable? I referenced apache/spark#48406.

Should I submit a separate pr or can it be completed in this one?

also cc @Yikun @yaooqinn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make a separate one : #78

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make a separate one : #78

Let me rebase this one

@LuciferYang LuciferYang changed the title Publish 3.5.4 to docker registry Publish 3.5.4 to docker registry (#77) Dec 22, 2024
@LuciferYang LuciferYang changed the title Publish 3.5.4 to docker registry (#77) Publish 3.5.4 to docker registry Dec 22, 2024
@LuciferYang LuciferYang merged commit 6b917ce into apache:master Dec 22, 2024
8 checks passed
@LuciferYang
Copy link
Contributor Author

all test passed, merged into master

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Dec 22, 2024 •
edited
Loading

It looks like the publish to apache/spark was successful:

cc @HyukjinKwon @Yikun @dongjoon-hyun @yaooqinn

And I have submitted a pr to docker-library/official-images#18156

@dongjoon-hyun
Copy link
Member

Thank you, @LuciferYang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciferYang @dongjoon-hyun @HyukjinKwon