Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-6122: POC cancel submitted not started async task #2790

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

QFREEE
Copy link
Contributor

@QFREEE QFREEE commented Oct 22, 2024

https://issues.apache.org/jira/browse/SOLR-6122

Description

Cancel submitted but not started collections api call

Solution

The code provided only applies to non distributed overseer mode for now.

Add a force query param to deleteStatus to allow it remove submitted but not started tasks.

When force == true, will remove submitted task from collection-queue-work and asyncid map.

In overseerTaskProceser, there will be a risk that even if task is removed from collection-queue-work, task could still remain in in-memory blockedTask, thus still be excuted. We check if the async id is present in async id before excuting to try to mitigate it

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@QFREEE QFREEE changed the title SOLR-6122: POC cancel submitted not started task SOLR-6122: POC cancel submitted not started async task Oct 22, 2024
@dsmiley dsmiley self-requested a review October 23, 2024 12:29
@dsmiley
Copy link
Contributor

dsmiley commented Oct 27, 2024

I'll give it a look when you think it's ready (I see it's Draft). Two checks fail.

@github-actions github-actions bot added the tests label Oct 30, 2024
@QFREEE QFREEE marked this pull request as ready for review October 30, 2024 19:01
@QFREEE QFREEE marked this pull request as draft October 30, 2024 19:08
@QFREEE QFREEE marked this pull request as ready for review October 30, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants