Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pipeline, why not returning 1 on python test error?????? #457

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

3dprintscanner
Copy link

@3dprintscanner 3dprintscanner commented May 4, 2019

This change captures the exit code from the python unit tests. This now results in a failed build as the tests cannot find the python -> c++ bindings. This appears to be a conda / pyenv issue and seems like the build python module isn't getting loading into the environment when traversing into the test directory.

# save the package at given folder, then we can upload using singa-*.tar.bz2 suffix=$TRAVIS_JOB_NUMBER #TZ=Asia/Singapore date +%Y-%m-%d-%H-%M-%S`
export CONDA_BLD_PATH=~/conda-bld-$suffix
mkdir $CONDA_BLD_PATH

conda build tool/conda/singa --python 3.6
conda install --use-local singa
cd test/python
$HOME/miniconda/bin/python run.py
echo $?
`

This causes a module import error and the tests fail.

Would like to debug, however need access to the build agent to further investigate the best way of setting this up

@3dprintscanner
Copy link
Author

Further to this, it appears that on Ubuntu 18.04, the conda config for building the library pulls the 3.x.x version of libprotobuf, changing the build to go against the 2.x.x protobuf version causes this to break from a broken linked dependency in _singa_wrap.so

@moazreyad
Copy link
Contributor

This PR is required for enabling the python test with continuous integration. Without this PR, the user must check the error messages of the python test manually by looking at the log and the python test errors are not shown as check errors in Travis CI or Github Actions.

Here is the Gihub action with python errors without this PR (the check passes even if there are errors) and here is the Github action with this PR (the check fails correctly due to errors in python test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants