Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some GitHub Actions #1153

Closed
wants to merge 12 commits into from
Closed

Conversation

tinyAdapter
Copy link

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.74%. Comparing base (05876f9) to head (bf5f6ed).
Report is 219 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files          85       85           
  Lines        4524     4524           
=======================================
  Hits         2748     2748           
  Misses       1776     1776           
Flag Coverage Δ
singa-cpp 60.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lzjpaul
Copy link
Contributor

lzjpaul commented Mar 25, 2024

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via [email protected]

Thanks,
Zhaojing.

@lzjpaul
Copy link
Contributor

lzjpaul commented Mar 25, 2024

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via [email protected]

Thanks,
Zhaojing.

@tinyAdapter tinyAdapter changed the base branch from master to dev-postgresql March 25, 2024 08:56
@tinyAdapter
Copy link
Author

Seems the updated action has been reflected in the latest dev-postgresql branch. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants