[type:fix] Make the default value of ShenyuDubboService annotation equal to that of DubboService annotation #5816
+168
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual to that of DubboService annotation
moremind
requested changes
Nov 27, 2024
|
|
||
| /** | ||
| * Alias for {@link DubboService#loadbalance()} . | ||
| * | ||
| * @return the string | ||
| */ | ||
| @AliasFor(annotation = DubboService.class) | ||
| String loadbalance() default LoadbalanceRules.RANDOM; | ||
| String loadbalance() default LoadbalanceRules.EMPTY; |
There was a problem hiding this comment.
This is the default value for DubboService annotation. Empty and random are different. If the configuration file specifies load balancing is RoundRobin, then the final result for Empty is RoundRobin.
yu199195
reviewed
Nov 27, 2024
| @@ -202,7 +199,7 @@ | |||
| * @return the int | |||
| */ | |||
| @AliasFor(annotation = DubboService.class) | |||
| int delay() default 0; | |||
| int delay() default -1; | |||
There was a problem hiding this comment.
What's the difference between -1 and 0?
There was a problem hiding this comment.
There was a problem hiding this comment.
Keeping the default values consistent can make the behavior of two annotations consistent. Even if there is currently no difference between the two, they are still compatible with Dubbo's future modifications
yu199195
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5815
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.