Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ShenyuDubboService annotation some default value not equals DubboService annotation #5815

Open
1 task done
eye-gu opened this issue Nov 27, 2024 · 0 comments · May be fixed by #5816
Open
1 task done

[BUG] ShenyuDubboService annotation some default value not equals DubboService annotation #5815

eye-gu opened this issue Nov 27, 2024 · 0 comments · May be fixed by #5816
Labels
type: bug Something isn't working

Comments

@eye-gu
Copy link
Contributor

eye-gu commented Nov 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

https://github.com/apache/shenyu/blob/master/shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/annotation/ShenyuDubboService.java

https://github.com/apache/dubbo/blob/3.3/dubbo-common/src/main/java/org/apache/dubbo/config/annotation/DubboService.java

You can see that some default values for the two annotations are different. For example, timeout, with a default value of -1 in DubboService and 0 in ShenyuDubboService, results in some metadata being registered with a timeout of 0, while others have a timeout of 3000.

iShot_2024-11-27_14 44 24
iShot_2024-11-27_14 44 42

Expected Behavior

No response

Steps To Reproduce

No response

Environment

ShenYu version(s):

Debug logs

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
1 participant