Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GlobalPropertiesNodePath #34325

Merged
merged 1 commit into from
Jan 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public static String getActiveVersionPath() {
* @param path path
* @return true or false
*/
public static boolean issActiveVersionPath(final String path) {
public static boolean isActiveVersionPath(final String path) {
Pattern pattern = Pattern.compile(getActiveVersionPath() + "$", Pattern.CASE_INSENSITIVE);
Matcher matcher = pattern.matcher(path);
return matcher.find();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void assertGetActiveVersionPath() {
}

@Test
void assertIssActiveVersionPath() {
assertTrue(GlobalPropertiesNodePath.issActiveVersionPath("/props/active_version"));
void assertIsActiveVersionPath() {
assertTrue(GlobalPropertiesNodePath.isActiveVersionPath("/props/active_version"));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public Collection<Type> getSubscribedTypes() {

@Override
public void handle(final ContextManager contextManager, final DataChangedEvent event) {
if (!GlobalPropertiesNodePath.issActiveVersionPath(event.getKey())) {
if (!GlobalPropertiesNodePath.isActiveVersionPath(event.getKey())) {
return;
}
ActiveVersionChecker.checkActiveVersion(contextManager, event);
Expand Down
Loading