Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin flag to root user in global.yaml #34223

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add admin flag to root user in global.yaml #34223

merged 1 commit into from
Jan 2, 2025

Conversation

RaigorJiang
Copy link
Contributor

For #25149

@RaigorJiang RaigorJiang added this to the 5.5.2 milestone Jan 2, 2025
@RaigorJiang
Copy link
Contributor Author

Hi @linghengqian
There are some exceptions in NativeTest of this PR. Can you please help me check if they are related to the config changes?

https://github.com/apache/shardingsphere/actions/runs/12579571653/job/35060916826?pr=34223

image

linghengqian
linghengqian approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaigorJiang I don't think the failure of NativeTest CI will prevent the current PR from being merged, the failure is just some missing JSON entries. I will submit a PR later to update the GraalVM Reachability Metadata.

@RaigorJiang
Copy link
Contributor Author

@RaigorJiang I don't think the failure of NativeTest CI will prevent the current PR from being merged, the failure is just some missing JSON entries. I will submit a PR later to update the GraalVM Reachability Metadata.

@linghengqian OK, thank you very much for your inspection.

@RaigorJiang RaigorJiang merged commit b15227b into apache:master Jan 2, 2025
147 of 148 checks passed
@RaigorJiang RaigorJiang deleted the yaml-admin branch January 2, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghengqian linghengqian linghengqian approved these changes

Assignees
No one assigned
Labels
feature:authority type: refactor
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@RaigorJiang @linghengqian