Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix federation query binary type data query #31346

Merged
merged 3 commits into from
May 26, 2024
Merged

Conversation

zihaoAK47
Copy link
Member

Fixes #31247.

Changes proposed in this pull request:
Fix federated query failed to get binary type data, test single projection column and multiple projection column queries in e2e federated query scenario.

In the MetaData assertion test for the federated query scenario, the assertion test for the ColumnType is skipped, and mysql makes some implicit transformations to the query result according to the type. Obtained through SQLFederationResultSetMetaData ColumnType is difficult with mysql ColumnType consistent.

SELECT 1=1;
actual: BOOLEAN  expected: BIGINT

SELECT type_bit FROM t_product_extend;
actual: BIGINT  expected: BIT

SELECT type_binary FROM t_product_extend;
actual: VARBINARY expected: BINARY

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu merged commit 2a9dabb into apache:master May 26, 2024
141 checks passed
@zihaoAK47 zihaoAK47 deleted the dev branch May 27, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The federated query cannot get data of binary type
2 participants