Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong unit test when ShardingSphereRule has been refactored #30678

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Remove wrong unit test when ShardingSphereRule has been refactored #30678

merged 1 commit into from
Mar 28, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Mar 28, 2024 •
edited
Loading

Ref #28724.

Changes proposed in this pull request:

  • Remove wrong unit test when ShardingSphereRule has been refactored

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.5.0 milestone Mar 28, 2024
@FlyingZC FlyingZC merged commit 92cc7b9 into apache:master Mar 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlyingZC FlyingZC FlyingZC approved these changes

Assignees
No one assigned
Labels
in: test type: refactor
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@strongduanmu @FlyingZC