Revise MissingRequiredTargetDatabaseException and check target database is exists #30395
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandynz
requested changes
Mar 5, 2024
| ShardingSphereDatabase targetDatabase = PipelineContextManager.getProxyContext().getContextManager().getDatabase(sqlStatement.getTargetDatabaseName()); | ||
| ShardingSpherePreconditions.checkNotNull(targetDatabase, () -> new PipelineInvalidParameterException(String.format("Target database `%s` is not exists", | ||
| sqlStatement.getTargetDatabaseName()))); | ||
| targetDatabaseName = targetDatabase.getName(); |
There was a problem hiding this comment.
Is targetDatabaseName = targetDatabase.getName(); necessary? Migration is compatible with upper and lower database name.
There was a problem hiding this comment.
Improved, I find MIGRATE TABLE DistSQL now must select database, just like
mysql> MIGRATE TABLE ds_0.t_order_copy INTO sharding_DB2.t_order;
ERROR 1046 (3D000): No database selected
mysql> use sharding_db
Database changed
So I improve the exception message and check the target database is really exists
azexcy
changed the title
sandynz
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.