Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing SQL Server INSERT INTO sql #29195 #29916

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Support parsing SQL Server INSERT INTO sql #29195 #29916

merged 7 commits into from
Jan 30, 2024

Conversation

yydeng626
Copy link
Collaborator

@yydeng626 yydeng626 commented Jan 30, 2024 •
edited
Loading

Fixes #29195.

Changes proposed in this pull request:

  • support sql
1. INSERT INTO #t VALUES (99)

2. INSERT INTO ##test
VALUES (1, 1)

3.SELECT * FROM ##test  // duplicate sql

4.SELECT TOP 100 id=CAST(_id as VARBINARY(1000))
FROM OPENROWSET('CosmosDB',
                'Your-account

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@yydeng626
Support parsing SQL Server SELECT ProductId, sql apache#29159
5a98b5a
@yydeng626
Merge branch 'master' into 29159
a0110ae
@yydeng626
Merge branch 'master' into 29159
b6277a1 
# Conflicts:
#	parser/sql/dialect/sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
#	test/it/parser/src/main/resources/case/dml/insert.xml
#	test/it/parser/src/main/resources/case/dml/select-special-function.xml
#	test/it/parser/src/main/resources/sql/supported/dml/insert.xml
#	test/it/parser/src/main/resources/sql/supported/dml/select-special-function.xml
@yydeng626
fix code style
27e2749
@yydeng626
Merge branch 'master' into 29159
5ab48b2
@yydeng626
Support parsing SQL Server INSERT INTO sql apache#29195
07a6a68
@yydeng626
Merge branch 'master' into 29159
66890b7 
# Conflicts:
#	test/it/parser/src/main/resources/case/dml/insert.xml
#	test/it/parser/src/main/resources/sql/supported/dml/insert.xml
@strongduanmu strongduanmu added this to the 5.5.0 milestone Jan 30, 2024
strongduanmu
strongduanmu approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, merged. Please go ahead.

@strongduanmu strongduanmu merged commit 30a492d into apache:master Jan 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: SQLServer in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Support parsing SQL Server INSERT INTO sql
2 participants
@yydeng626 @strongduanmu