Support parsing SQL Server INSERT INTO sql #29842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/it/parser/src/main/resources/case/dml/insert.xml # test/it/parser/src/main/resources/sql/supported/dml/insert.xml
|
When you have time please add label and have a look at my PR. Thanks! |
strongduanmu
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29169
Changes proposed in this pull request:
added test case to cover scenario:
INSERT INTO #Test VALUES (N'OC', N'Ounces', GETDATE())INSERT INTO #Test SELECT * FROM Production.UnitMeasurethe following case is already covered and was created in this PR
SELECT COUNT(*) AS [Number of rows] FROM #TestBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.