Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancy in Sharing Specification in Create View Oracle #29552

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

ilyasahsan123
Copy link
Contributor

@ilyasahsan123 ilyasahsan123 commented Dec 26, 2023

Fixes #29551.

Changes proposed in this pull request:

  • Simplify Sharing Specification in Create View Oracle

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@ilyasahsan123
Copy link
Contributor Author

This is just a minor nitpick, @strongduanmu. Is it acceptable?

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilyasahsan123, thank you for your contribution. Can you show the original sql sytax in oracle offical doc? And add sql parse test case for this change?

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I checked the createSharingClause syntax and they do have redundancy. Thank you for your contribution, merged.

createSharingClause
    : (SHARING EQ_ (METADATA | DATA | EXTENDED DATA | NONE))?
    ;

@strongduanmu strongduanmu merged commit 70c9058 into apache:master Dec 26, 2023
133 checks passed
@ilyasahsan123
Copy link
Contributor Author

Thanks for your feedback and approval, @strongduanmu. It is also my bad in giving PR name. I should rename it to something like "remove redundancy".

Thanks anyway.

@strongduanmu
Copy link
Member

Thanks for your feedback and approval, @strongduanmu. It is also my bad in giving PR name. I should rename it to something like "remove redundancy".

Thanks anyway.

Yes, you can try to modify the PR title. In addition, it seems that you are familiar with ANTLR, are you interested in getting involved in more SQL parsing tasks? For example, Oracle and SQLServer. ShardingSphere SQL parsing will get much better if you can get involved. 😁

@ilyasahsan123 ilyasahsan123 changed the title Simplify Sharing Specification in Create View Oracle Remove redundancy in Sharing Specification in Create View Oracle Dec 26, 2023
@ilyasahsan123
Copy link
Contributor Author

Yes, I am very interested in getting involved in the parsing world and I am currently looking into following issues:

Are there any GitHub issues that I can get involved in?

@strongduanmu
Copy link
Member

@ilyasahsan123 You can participate in these missions first, and we will post new missions later, so you can follow and participate in them.

@ilyasahsan123
Copy link
Contributor Author

Excited. Thanks for the info, @strongduanmu.

@ilyasahsan123 ilyasahsan123 deleted the 29551 branch December 31, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Redundancy in Sharing Specification in Create View Oracle
2 participants