-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundancy in Sharing Specification in Create View Oracle #29552
Conversation
This is just a minor nitpick, @strongduanmu. Is it acceptable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ilyasahsan123, thank you for your contribution. Can you show the original sql sytax in oracle offical doc? And add sql parse test case for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I checked the createSharingClause syntax and they do have redundancy. Thank you for your contribution, merged.
createSharingClause
: (SHARING EQ_ (METADATA | DATA | EXTENDED DATA | NONE))?
;
Thanks for your feedback and approval, @strongduanmu. It is also my bad in giving PR name. I should rename it to something like "remove redundancy". Thanks anyway. |
Yes, you can try to modify the PR title. In addition, it seems that you are familiar with ANTLR, are you interested in getting involved in more SQL parsing tasks? For example, Oracle and SQLServer. ShardingSphere SQL parsing will get much better if you can get involved. 😁 |
@ilyasahsan123 You can participate in these missions first, and we will post new missions later, so you can follow and participate in them. |
Excited. Thanks for the info, @strongduanmu. |
Fixes #29551.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.