Add more unit tests for BroadcastSQLRouter (#28521) #29095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Dec 3, 2023
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class BroadcastSqlRouterTest { |
There was a problem hiding this comment.
Please remove public modifier in unit test
There was a problem hiding this comment.
I'll fix it right away.
| * test For BroadcastSQLRouter.createRouteContext(). | ||
| */ | ||
| @Test | ||
| public void assertCreateBroadcastRouteContextWithMultiDataSource() throws SQLException { |
There was a problem hiding this comment.
Please remove public modifier in unit test
There was a problem hiding this comment.
I'll fix it right away.
|
|
||
| public class BroadcastSqlRouterTest { | ||
|
|
||
| /** |
There was a problem hiding this comment.
Please remove javadoc in unit test
There was a problem hiding this comment.
I'll fix it right away.
|
@strongduanmu I have adjusted the code according to CR rules，thank you for your CR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28521
Changes proposed in this pull request:
Add more unit tests for BroadcastSQLRouter
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.