Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL parsing Enhancement: add more SQL test case for create-materialized-view #29081

Merged
merged 1 commit into from
Nov 20, 2023
Merged

SQL parsing Enhancement: add more SQL test case for create-materialized-view #29081

merged 1 commit into from
Nov 20, 2023

Conversation

chakkk309
Copy link
Contributor

@chakkk309 chakkk309 commented Nov 19, 2023 •
edited
Loading

Fixes #27042, #27044.

Changes proposed in this pull request:

  • Add test case SQL

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.2 milestone Nov 20, 2023
strongduanmu
strongduanmu approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit 3780487 into apache:master Nov 20, 2023
15 checks passed
@strongduanmu strongduanmu mentioned this pull request Nov 20, 2023
Closed
@chakkk309 chakkk309 deleted the create-materialized-view branch November 20, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: Oracle in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Support parsing Oracle CREATE MATERIALIZED sql
2 participants
@chakkk309 @strongduanmu