Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serverTimezone=UTC parameter at MySQLConnectionPropertiesParser and E2E #29067

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

azexcy
Copy link
Contributor

@azexcy azexcy commented Nov 17, 2023

Because of upgrade to MySQL Connector/J 8.x, Configuring serverTimezone alone is effective, however, the default time zone in the program is used whenserverTimezone is configured individually in MySQL Connector/J 5.1.x

So, it's better add the parameter manually if needed

refer

  1. https://dev.mysql.com/doc/refman/8.0/en/time-zone-support.html
  2. https://dev.mysql.com/doc/connectors/en/connector-j-time-instants.html
  3. https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/news-8-0-23.html

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@azexcy
Copy link
Contributor Author

azexcy commented Nov 17, 2023

Related code com.mysql.cj.protocol.a.NativeProtocol
image

@azexcy azexcy marked this pull request as ready for review November 17, 2023 08:33
@azexcy azexcy changed the title Remove serverTimezone=UTC at MySQLConnectionPropertiesParser and E2E Remove serverTimezone=UTC parameter at MySQLConnectionPropertiesParser and E2E Nov 17, 2023
@azexcy azexcy added this to the 5.4.2 milestone Nov 17, 2023
@terrymanu terrymanu merged commit 5a4f36f into apache:master Nov 17, 2023
133 checks passed
@azexcy azexcy deleted the timezone2 branch November 17, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants