New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize PropertiesConverter #29065

Merged

RaigorJiang merged 1 commit into apache:master from jiangML:dev-distsql-props-out

Nov 17, 2023

Contributor

jiangML commented Nov 17, 2023 •

edited

Loading

Fixes #29039.

Changes proposed in this pull request:

Outputs an empty string when Properties is empty
Output after sorting

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.


          Optimize PropertiesConverter

380e389

RaigorJiang approved these changes

View reviewed changes

RaigorJiang merged commit 1003190 into apache:master

133 checks passed

RaigorJiang added this to the 5.4.2 milestone

RaigorJiang added type: refactor feature: DistSQL labels

jiangML deleted the dev-distsql-props-out branch

November 17, 2023 06:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: DistSQL type: refactor