Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CDCImporter process FinishedRecord, and advise CDC client #28953

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Improve CDCImporter process FinishedRecord, and advise CDC client #28953

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
152f56c
Improve CDCImporter finished flag
azexcy Nov 6, 2023
664333d
Merge remote-tracking branch 'upstream/master' into fix
azexcy Nov 6, 2023
f39232e
Improve CDCImporter process FinishedRecord
azexcy Nov 7, 2023
cff349c
Add RetryStreamingExceptionHandler
azexcy Nov 7, 2023
4632a89
Merge remote-tracking branch 'upstream/master' into fix
azexcy Nov 7, 2023
1b9618a
Add reconnect case
azexcy Nov 7, 2023
9cbbfcb
Refactor cdc exception handler
azexcy Nov 7, 2023
33b1c19
Improve parameter and error log
azexcy Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/importer/CDCImporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ protected void runBlocking() {
} else {
doWithoutSorting(channelProgressPairs);
}
if (channelProgressPairs.isEmpty()) {
if (channelProgressPairs.isEmpty() && ackCache.estimatedSize() == 0) {
break;
}
azexcy marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down Expand Up @@ -239,6 +239,7 @@ public void ack(final String ackId) {
each.getLeft().getChannel().ack(Collections.singletonList(ackPosition.getLastRecord()));
each.getLeft().getJobProgressListener().onProgressUpdated(new PipelineJobProgressUpdatedParameter(ackPosition.getDataRecordCount()));
}
ackCache.invalidate(ackId);
}

@Override
Expand Down