Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28518 Add unit tests for SingleIndexReviser #28932

Merged
merged 2 commits into from
Jan 24, 2024
Merged

#28518 Add unit tests for SingleIndexReviser #28932

merged 2 commits into from
Jan 24, 2024

Conversation

anogueiraFlywire
Copy link
Contributor

@anogueiraFlywire anogueiraFlywire commented Nov 3, 2023 •
edited
Loading

Fixes #28518.

Changes proposed in this pull request:

  • Add unit tests for SingleIndexReviser

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation. N/A
  • I have added corresponding unit tests for my changes. N/A

@anogueiraFlywire anogueiraFlywire force-pushed the 28518 branch 2 times, most recently from 32a97f3 to fdecd37 Compare November 3, 2023 15:03
@anogueiraFlywire anogueiraFlywire marked this pull request as ready for review November 3, 2023 15:06
@tuichenchuxin tuichenchuxin added this to the 5.4.2 milestone Nov 27, 2023
@anogueiraFlywire
Copy link
Contributor Author

Hi @tuichenchuxin
Is this ready to be merged?

@tuichenchuxin tuichenchuxin merged commit b1cfe2e into apache:master Jan 24, 2024
15 checks passed
@tuichenchuxin
Copy link
Contributor

Hi @tuichenchuxin Is this ready to be merged?
LGTM, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuichenchuxin tuichenchuxin tuichenchuxin approved these changes

Assignees
No one assigned
Labels
in: test type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add more unit tests for SingleIndexReviser
2 participants
@anogueiraFlywire @tuichenchuxin