New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Unit test for NewGlobalNode#getGlobalRuleVersionNode #28831

Merged

zhaojinchao95 merged 2 commits into apache:master from rajeshwarrao055:28493

Oct 22, 2023

Contributor

rajeshwarrao055 commented Oct 21, 2023 •

edited

Loading

Fixes #28493.

Changes proposed in this pull request:

Added unit test for NewGlobalNode#getGlobalRuleVersionNode, asserts expected result

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.


          Adding Unit test for NewGlobalNode#getGlobalRuleVersionNode

ff00168

zhaojinchao95 added the in: test label

zhaojinchao95 added this to the 5.4.2 milestone


          Fixing spotless violations introduced after adding Unit test

ace0680

zhaojinchao95 approved these changes

View reviewed changes

zhaojinchao95 merged commit 5e390f2 into apache:master

15 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels