Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of custom sqldelete logic and DeleteMerge logic #28806

Closed
wants to merge 1 commit into from

Conversation

kanha-gupta
Copy link
Contributor

@kanha-gupta kanha-gupta commented Oct 19, 2023

Ref #28754
Changes proposed in this pull request:

  1. Creation of a custom SqlDelete class to parse merge statements
  2. Creation of a custom MergeDeleteOperation class to combine the statements of delete and merge together

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@kanha-gupta
Copy link
Contributor Author

@strongduanmu please review :)

@kanha-gupta
Copy link
Contributor Author

Hey @strongduanmu any updates with this PR ?

@kanha-gupta kanha-gupta deleted the merge1 branch January 6, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants