Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for update in Merge statements #28789

Merged
merged 2 commits into from
Oct 17, 2023
Merged

support for update in Merge statements #28789

merged 2 commits into from
Oct 17, 2023

Conversation

kanha-gupta
Copy link
Contributor

@kanha-gupta kanha-gupta commented Oct 17, 2023 •
edited
Loading

Ref #28754

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@kanha-gupta
Copy link
Contributor Author

@strongduanmu Please review :)

@strongduanmu strongduanmu added this to the 5.4.2 milestone Oct 17, 2023
strongduanmu
strongduanmu approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kanha-gupta, this pr looks so great.

@strongduanmu strongduanmu merged commit 216da20 into apache:master Oct 17, 2023
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
feature: SQL federation type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kanha-gupta @strongduanmu