Refactor sequentialFlush at PipelineDataSourceSink of Pipeline #28734

azexcy · 2023-10-12T09:07:46Z

Extracting methods to the outer layer

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.

.../java/org/apache/shardingsphere/data/pipeline/core/importer/sink/PipelineDataSourceSink.java

Refactor sequentialFlush at PipelineDataSourceSink

3641bfc

azexcy added type: refactor feature: pipeline labels Oct 12, 2023

azexcy added this to the 5.4.2 milestone Oct 12, 2023

sandynz requested changes Oct 13, 2023

View reviewed changes

.../java/org/apache/shardingsphere/data/pipeline/core/importer/sink/PipelineDataSourceSink.java Outdated Show resolved Hide resolved

Refactor doFlush

44a5608

sandynz requested changes Oct 15, 2023

View reviewed changes

Improve and add TODO

d175ee1

sandynz approved these changes Oct 16, 2023

View reviewed changes

sandynz merged commit 559f121 into apache:master Oct 16, 2023
24 checks passed

azexcy deleted the pipeline branch October 17, 2023 07:15

Provide feedback