Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DatabaseConfiguration.getDataSources instead of getStorageResource #28658

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Use DatabaseConfiguration.getDataSources instead of getStorageResource #28658

merged 1 commit into from
Oct 7, 2023

Conversation

terrymanu
Copy link
Member

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have added corresponding unit tests for my changes.

@terrymanu terrymanu added this to the 5.4.2 milestone Oct 7, 2023
@FlyingZC FlyingZC merged commit e05f948 into apache:master Oct 7, 2023
25 of 26 checks passed
@terrymanu terrymanu deleted the dev branch October 7, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlyingZC FlyingZC FlyingZC approved these changes

@taojintianxia taojintianxia taojintianxia approved these changes

Assignees
No one assigned
Labels
in: metadata type: refactor
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@terrymanu @taojintianxia @FlyingZC