Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle alter table modifylobStorageClause parse rule #28628

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

zihaoAK47
Copy link
Member

Ref #26990.

Changes proposed in this pull request:

  • Add oracle alter table modifylobStorageClause parse rule
  • Add test sql

Before committing this PR, I'm sure that I have checked the following options:

  • [ ✓] My code follows the code of conduct of this project.
  • [ ✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [ ✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [ ✓] I have added corresponding unit tests for my changes.

@@ -1600,11 +1590,6 @@

<alter-table sql-case-id="alter_table_modify_lob_nocache">
<table name="employees" start-index="12" stop-index="20" />
<modify-column>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove modify-column?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define incorrect use cases, and these SQL statements should be parsed by this syntax rule
Ref: https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877__I2104157

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define incorrect use cases, and these SQL statements should be parsed by this syntax rule Ref: https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-TABLE.html#GUID-552E7373-BF93-477D-9DA3-B2C9386F2877__I2104157

Got it, thank you.

@strongduanmu strongduanmu merged commit f3dec3c into apache:master Oct 4, 2023
127 checks passed
@zihaoAK47 zihaoAK47 deleted the dev_26990 branch October 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants