support information_schema.PARAMETERS query in cluster mod #28620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JustRun98, can you take a look for checkstyle error? |
I have fix it |
tuichenchuxin
requested changes
Oct 8, 2023
| if (CLUSTER_INFORMATION.equals(entry.getKey())) { | ||
| tableData.getRows().add(new ShardingSphereRowData(Collections.singletonList(ShardingSphereVersion.VERSION))); | ||
|
|
||
| Optional<ShardingSphereSchema> informationSchemaSchema = Optional.ofNullable(metaData.getDatabase("information_schema")).map(database -> database.getSchema("information_schema")); |
There was a problem hiding this comment.
I think information_schema should in shardingsphere database.
There was a problem hiding this comment.
@tuichenchuxin
are you guys expect that all the metadata table's data should presist in shardingsphere database?
I think if so the databases like information_schema will be totally useless
There was a problem hiding this comment.
it'll be like this.
database:shardingsphere
- schema: information_schema
|
Since this pr has long time no response, I will close it. If you are interested, you are welcome to submit a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24378.
Changes proposed in this pull request:
support information_schema.PARAMETERS query in cluster mod
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.