Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add world map of contributors to shardingsphere project #28588

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

Zhenye-Na
Copy link
Contributor

@Zhenye-Na Zhenye-Na commented Sep 26, 2023

Fixes #26521

Changes proposed in this pull request:

  • Created a new Github Actions to automatically update the generated SVG based on Cronjob

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@Zhenye-Na Zhenye-Na marked this pull request as ready for review September 26, 2023 04:53
Copy link
Contributor

@taojintianxia taojintianxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest change the PR as followings :

  1. move the content of contributors-map to nightly-build.yml
  2. attach the screenshot of the svg file in the corresponding issue

BTW, there are some code of conducts for github : https://shardingsphere.apache.org/community/cn/involved/conduct/code/
so, for the original file contributors-map.yaml , it's not a good name ^_^

@taojintianxia taojintianxia added this to the 5.4.2 milestone Sep 27, 2023
@Zhenye-Na
Copy link
Contributor Author

I suggest change the PR as followings :

1. move the content of contributors-map to nightly-build.yml

2. attach the screenshot of the svg file in the corresponding issue

BTW, there are some code of conducts for github : https://shardingsphere.apache.org/community/cn/involved/conduct/code/ so, for the original file contributors-map.yaml , it's not a good name ^_^

Hi @taojintianxia

Thanks for the fast response.

  1. I will make a new revision to move this to nightly-build.yml
  2. I will attach the screenshot as well in the original issue and this PR for testing/validation purpose
  3. Regarding the naming convention, sorry for the inconvenience, I will double check the link you paste here to avoid this in the future.

Will let you know once I publish a new revision of PR

Thanks

@Zhenye-Na Zhenye-Na marked this pull request as draft October 1, 2023 05:53
@Zhenye-Na
Copy link
Contributor Author

I have created a dummy workflow in my own fork with the this workflow executed successfully, job history

I have attached the generated image as follows:

image

@Zhenye-Na Zhenye-Na marked this pull request as ready for review October 1, 2023 06:03
@taojintianxia taojintianxia merged commit 84522b1 into apache:master Oct 8, 2023
13 checks passed
@Zhenye-Na Zhenye-Na deleted the 26521 branch October 8, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stargazers worldmap in ShardingSphere README page
2 participants