Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal refactor of oracle dml statement parameter parse #28462

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Minimal refactor of oracle dml statement parameter parse #28462

merged 3 commits into from
Sep 19, 2023

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Sep 19, 2023 •
edited
Loading

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Minimal refactor of oracle dml statement parameter parse

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.1 milestone Sep 19, 2023
@zhaojinchao95 zhaojinchao95 merged commit bbc2b19 into apache:master Sep 19, 2023
@strongduanmu strongduanmu deleted the dev-0919 branch September 19, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees
No one assigned
Labels
db: Oracle in: SQL parse type: refactor
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@strongduanmu @zhaojinchao95