Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing SQL Server INSERT INTO sql #29195

Closed
FlyingZC opened this issue Nov 24, 2023 · 13 comments · Fixed by #29916
Closed

Support parsing SQL Server INSERT INTO sql #29195

FlyingZC opened this issue Nov 24, 2023 · 13 comments · Fixed by #29916

Comments

@FlyingZC
Copy link
Member

Background

Hi community.
This issue is for #29149.

The ShardingSphere SQL parser engine helps users to parse SQL to create the AST (Abstract Syntax Tree) and visit the AST to get SQLStatement (Java Object). Currently, we are planning to enhance the support for SQL Server SQL parsing in ShardingSphere.

More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more SQL Server sql parsing, as follows:

INSERT INTO #t VALUES (99)

link

INSERT INTO ##test
VALUES (1, 1)

link

SELECT * FROM ##test

link

SELECT * FROM ##test

link

SELECT TOP 100 id=CAST(_id as VARBINARY(1000))
FROM OPENROWSET('CosmosDB',
                'Your-account

link

Process

  1. First confirm that this is a correct SQL Server sql syntax, if not please leave a message under the issue and ignore it;
  2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with SQL Server SQLs
@professorabhay
Copy link

Hey @FlyingZC ! Seems familiar to me.
I'm working on it.

@strongduanmu
Copy link
Member

@professorabhay Welcome, I will assign it to you.

@professorabhay
Copy link

Hey @strongduanmu, I need some help. Please tell me some more details about implementation and the details about dir .

@strongduanmu
Copy link
Member

Hi @professorabhay, you can refer this pr - #29138, it's a good example.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Dec 26, 2023
@Eeshu-Yadav
Copy link

Hey @strongduanmu ,plzz assign it to me.

@strongduanmu
Copy link
Member

@Eeshu-Yadav Assigned.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Jan 28, 2024
@strongduanmu
Copy link
Member

Hi @Eeshu-Yadav, does this issue has any progress?

@github-actions github-actions bot removed the stale label Jan 29, 2024
@yydeng626
Copy link
Collaborator

@strongduanmu Please assign to me , I can do it

@strongduanmu
Copy link
Member

@yydeng626 Good job, I just assign this issue to you.

yydeng626 added a commit to yydeng626/shardingsphere that referenced this issue Jan 30, 2024
strongduanmu pushed a commit that referenced this issue Jan 30, 2024
* Support parsing SQL Server SELECT ProductId, sql #29159

* fix code style

* Support parsing SQL Server INSERT INTO sql #29195
@yydeng626
Copy link
Collaborator

@strongduanmu The issue is merged , please help to close it

@strongduanmu
Copy link
Member

Thank you for your remind @yydeng626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants