Skip to content

Commit

Permalink
Remove useless codes on MetaDataContextsFactory (#34345)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrymanu authored Jan 13, 2025
1 parent 3595d8e commit e5af00a
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ private static MetaDataContexts createByLocal(final MetaDataPersistService persi
ConfigurationProperties props = new ConfigurationProperties(param.getProps());
Map<String, ShardingSphereDatabase> databases = ExternalMetaDataFactory.create(param.getDatabaseConfigs(), props, instanceContext);
MetaDataContexts result = newMetaDataContexts(persistService, param, globalRuleConfigs, databases, props);
persistDatabaseConfigurations(result, param, persistService, instanceContext);
persistDatabaseConfigurations(result, param, persistService);
persistMetaData(result, persistService);
return result;
}
Expand Down Expand Up @@ -132,8 +132,7 @@ private static void closeGeneratedDataSources(final String databaseName, final M
}
}

private static void persistDatabaseConfigurations(final MetaDataContexts metadataContexts,
final ContextManagerBuilderParameter param, final MetaDataPersistService persistService, final ComputeNodeInstanceContext instanceContext) {
private static void persistDatabaseConfigurations(final MetaDataContexts metadataContexts, final ContextManagerBuilderParameter param, final MetaDataPersistService persistService) {
Collection<RuleConfiguration> globalRuleConfigs = metadataContexts.getMetaData().getGlobalRuleMetaData().getConfigurations();
persistService.persistGlobalRuleConfiguration(globalRuleConfigs, param.getProps());
for (Entry<String, ? extends DatabaseConfiguration> entry : param.getDatabaseConfigs().entrySet()) {
Expand Down

0 comments on commit e5af00a

Please sign in to comment.