Add GraalVM Reachability Metadata and corresponding nativeTest for Fi…

…rebird

RELEASE-NOTES.md

@@ -55,6 +55,7 @@
 1. Agent: Simplify the use of Agent's Docker Image - [#33356](https://github.com/apache/shardingsphere/pull/33356)
 1. Mode: Support modifying Hikari-CP configurations via props in standalone mode [#34185](https://github.com/apache/shardingsphere/pull/34185)
 1. Encrypt: Support insert statement rewrite use quote [#34259](https://github.com/apache/shardingsphere/pull/34259)
+1. Proxy Native: Add GraalVM Reachability Metadata and corresponding nativeTest for Firebird - [#34307](https://github.com/apache/shardingsphere/pull/34307)
 
 ### Bug Fixes
 

docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.cn.md

@@ -322,6 +322,8 @@ Args=--initialize-at-run-time=\
     io.grpc.netty.shaded.io.netty.util.AttributeKey
 ```
 
+ShardingSphere 的单元测试仅使用 Maven 模块 `io.github.linghengqian:hive-server2-jdbc-driver-thin` 来在 GraalVM Native Image 下验证可用性。
+
 8. 由于 https://github.com/oracle/graal/issues/7979 的影响，
 对应 `com.oracle.database.jdbc:ojdbc8` Maven 模块的 Oracle JDBC Driver 无法在 GraalVM Native Image 下使用。
 

docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/_index.en.md

@@ -336,6 +336,8 @@ Args=--initialize-at-run-time=\
     io.grpc.netty.shaded.io.netty.util.AttributeKey
 ```
 
+ShardingSphere's unit test only uses the Maven module `io.github.linghengqian:hive-server2-jdbc-driver-thin` to verify the availability under GraalVM Native Image.
+
 8. Due to https://github.com/oracle/graal/issues/7979 , 
 the Oracle JDBC Driver corresponding to the `com.oracle.database.jdbc:ojdbc8` Maven module cannot be used under GraalVM Native Image.
 

docs/document/content/user-manual/shardingsphere-jdbc/unsupported/p6spy/_index.cn.md

@@ -143,7 +143,7 @@ public class ExampleUtils {
              Statement statement = connection.createStatement()) {
             statement.execute("INSERT INTO t_order (user_id, order_type, address_id, status) VALUES (1, 1, 1, 'INSERT_TEST')");
             statement.executeQuery("SELECT * FROM t_order");
-            statement.execute("alter table t_order delete where order_id=1");
+            statement.execute("DELETE FROM t_order WHERE order_id=1");
         }
     }
 }

docs/document/content/user-manual/shardingsphere-jdbc/unsupported/p6spy/_index.en.md

@@ -145,7 +145,7 @@ public class ExampleUtils {
              Statement statement = connection.createStatement()) {
             statement.execute("INSERT INTO t_order (user_id, order_type, address_id, status) VALUES (1, 1, 1, 'INSERT_TEST')");
             statement.executeQuery("SELECT * FROM t_order");
-            statement.execute("alter table t_order delete where order_id=1");
+            statement.execute("DELETE FROM t_order WHERE order_id=1");
         }
     }
 }

docs/document/content/user-manual/shardingsphere-proxy/optional-plugins/seata-at/_index.cn.md

@@ -40,7 +40,7 @@ sdk install java 23-open
 sdk use java 23-open
 sdk install maven 3.9.9
 sdk use maven 3.9.9
-mvn clean dependency:get -Dartifact=org.apache.seata:seata-all:2.2.0
+mvn dependency:get -Dartifact=org.apache.seata:seata-all:2.2.0
 mvn -f ~/.m2/repository/org/apache/seata/seata-all/2.2.0/seata-all-2.2.0.pom dependency:tree | grep -v ':provided' | grep -v ':runtime'
 ```
 

docs/document/content/user-manual/shardingsphere-proxy/optional-plugins/seata-at/_index.en.md

@@ -41,7 +41,7 @@ sdk install java 23-open
 sdk use java 23-open
 sdk install maven 3.9.9
 sdk use maven 3.9.9
-mvn clean dependency:get -Dartifact=org.apache.seata:seata-all:2.2.0
+mvn dependency:get -Dartifact=org.apache.seata:seata-all:2.2.0
 mvn -f ~/.m2/repository/org/apache/seata/seata-all/2.2.0/seata-all-2.2.0.pom dependency:tree | grep -v ':provided' | grep -v ':runtime'
 ```
 

infra/database/type/firebird/pom.xml

@@ -33,6 +33,13 @@
             <version>${project.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>org.firebirdsql.jdbc</groupId>
+            <artifactId>jaybird</artifactId>
+            <scope>provided</scope>
+            <optional>true</optional>
+        </dependency>
+
         <dependency>
             <groupId>org.apache.shardingsphere</groupId>
             <artifactId>shardingsphere-test-util</artifactId>

infra/database/type/firebird/src/main/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParser.java

@@ -17,11 +17,14 @@
 
 package org.apache.shardingsphere.infra.database.firebird.connector;
 
+import lombok.SneakyThrows;
 import org.apache.shardingsphere.infra.database.core.connector.ConnectionProperties;
 import org.apache.shardingsphere.infra.database.core.connector.ConnectionPropertiesParser;
 import org.apache.shardingsphere.infra.database.core.connector.StandardConnectionProperties;
-import org.apache.shardingsphere.infra.database.core.connector.url.JdbcUrl;
-import org.apache.shardingsphere.infra.database.core.connector.url.StandardJdbcUrlParser;
+import org.firebirdsql.gds.impl.DbAttachInfo;
+import org.firebirdsql.gds.impl.GDSFactory;
+import org.firebirdsql.gds.impl.GDSType;
+import org.firebirdsql.jdbc.FBDriver;
 
 import java.util.Properties;
 
@@ -30,12 +33,18 @@
  */
 public final class FirebirdConnectionPropertiesParser implements ConnectionPropertiesParser {
 
-    private static final int DEFAULT_PORT = 3050;
-
+    @SneakyThrows(Exception.class)
     @Override
     public ConnectionProperties parse(final String url, final String username, final String catalog) {
-        JdbcUrl jdbcUrl = new StandardJdbcUrlParser().parse(url);
-        return new StandardConnectionProperties(jdbcUrl.getHostname(), jdbcUrl.getPort(DEFAULT_PORT), jdbcUrl.getDatabase(), null, jdbcUrl.getQueryProperties(), new Properties());
+        GDSType type = GDSFactory.getTypeForProtocol(url);
+        String databaseURL = GDSFactory.getDatabasePath(type, url);
+        DbAttachInfo dbAttachInfo = DbAttachInfo.parseConnectString(databaseURL);
+        String attachObjectName = dbAttachInfo.getAttachObjectName();
+        String databaseName = attachObjectName.contains("?") ? attachObjectName.split("\\?")[0] : attachObjectName;
+        Properties queryProperties = new Properties();
+        queryProperties.putAll(FBDriver.normalizeProperties(url, new Properties()));
+        return new StandardConnectionProperties(dbAttachInfo.getServerName(), dbAttachInfo.getPortNumber(),
+                databaseName, null, queryProperties, new Properties());
     }
 
     @Override

infra/database/type/firebird/src/test/java/org/apache/shardingsphere/infra/database/firebird/connector/FirebirdConnectionPropertiesParserTest.java

@@ -19,22 +19,24 @@
 
 import org.apache.shardingsphere.infra.database.core.connector.ConnectionProperties;
 import org.apache.shardingsphere.infra.database.core.connector.ConnectionPropertiesParser;
-import org.apache.shardingsphere.infra.database.core.exception.UnrecognizedDatabaseURLException;
 import org.apache.shardingsphere.infra.database.core.spi.DatabaseTypedSPILoader;
 import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
 import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
+import org.apache.shardingsphere.test.util.PropertiesBuilder;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.ArgumentsProvider;
 import org.junit.jupiter.params.provider.ArgumentsSource;
 
+import java.sql.SQLNonTransientConnectionException;
 import java.util.Properties;
 import java.util.stream.Stream;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class FirebirdConnectionPropertiesParserTest {
@@ -54,14 +56,29 @@ void assertNewConstructor(final String name, final String url, final String host
 
     @Test
     void assertNewConstructorFailure() {
-        assertThrows(UnrecognizedDatabaseURLException.class, () -> parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+        assertDoesNotThrow(() -> parser.parse("jdbc:firebirdsql:xxxxxxxx", null, null));
+        assertThrows(SQLNonTransientConnectionException.class, () -> parser.parse("jdbc:firebirdsql://localhost:c:/data/db/test.fdb", null, null));
     }
 
     private static class NewConstructorTestCaseArgumentsProvider implements ArgumentsProvider {
 
         @Override
         public Stream<? extends Arguments> provideArguments(final ExtensionContext extensionContext) {
-            return Stream.of(Arguments.of("simple", "jdbc:firebirdsql://127.0.0.1/foo_ds", "127.0.0.1", 3050, "foo_ds", null, new Properties()));
+            return Stream.of(
+                    Arguments.of("simple_first", "jdbc:firebirdsql://127.0.0.1/foo_ds", "127.0.0.1", 3050, "foo_ds", null, new Properties()),
+                    Arguments.of("simple_second", "jdbc:firebird://localhost:32783//var/lib/firebird/data/demo_ds_2.fdb",
+                            "localhost", 32783, "/var/lib/firebird/data/demo_ds_2.fdb", null, new Properties()),
+                    Arguments.of("simple_third", "jdbc:firebirdsql://localhost/database?socket_buffer_size=32767", "localhost", 3050, "database", null, PropertiesBuilder.build(
+                            new PropertiesBuilder.Property("socketBufferSize", "32767"))),
+                    Arguments.of("complex",
+                            "jdbc:firebirdsql://localhost/database?socket_buffer_size=32767"
+                                    + "&TRANSACTION_REPEATABLE_READ=concurrency,write,no_wait&columnLabelForName&soTimeout=1000&nonStandard2=value2",
+                            "localhost", 3050, "database", null, PropertiesBuilder.build(
+                                    new PropertiesBuilder.Property("socketBufferSize", "32767"),
+                                    new PropertiesBuilder.Property("TRANSACTION_REPEATABLE_READ", "concurrency,write,no_wait"),
+                                    new PropertiesBuilder.Property("columnLabelForName", ""),
+                                    new PropertiesBuilder.Property("soTimeout", "1000"),
+                                    new PropertiesBuilder.Property("nonStandard2", "value2"))));
         }
     }
 }