fix sonar issue in ColumnDefinitionSegmentBinder and ShardingRuleTest

apache · Dec 24, 2024 · c400ccb · c400ccb
1 parent 572998a
commit c400ccb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/...sharding/core/src/test/java/org/apache/shardingsphere/sharding/rule/ShardingRuleTest.java b/...sharding/core/src/test/java/org/apache/shardingsphere/sharding/rule/ShardingRuleTest.java
@@ -70,7 +70,6 @@
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.Map;
@@ -739,15 +738,6 @@ private ColumnSegment createColumnSegment(final String columnName, final String
         return result;
     }
 
-    private Map<String, String> createColumnTableNameMap() {
-        Map<String, String> result = new HashMap<>(4, 1F);
-        result.put("logic_Table.user_id", "logic_Table");
-        result.put("sub_Logic_Table.user_id", "sub_Logic_Table");
-        result.put("logic_Table.order_id", "logic_Table");
-        result.put("sub_Logic_Table.order_id", "sub_Logic_Table");
-        return result;
-    }
-
     @Test
     void assertGetDataNodesByTableName() {
         ShardingRule shardingRule = createMinimumShardingRule();

diff --git a/...ache/shardingsphere/infra/binder/engine/segment/column/ColumnDefinitionSegmentBinder.java b/...ache/shardingsphere/infra/binder/engine/segment/column/ColumnDefinitionSegmentBinder.java
@@ -49,7 +49,7 @@ public static ColumnDefinitionSegment bind(final ColumnDefinitionSegment segment
         ColumnSegment boundColumnSegment = ColumnSegmentBinder.bind(segment.getColumnName(), SegmentType.DEFINITION_COLUMNS, binderContext, tableBinderContexts, LinkedHashMultimap.create());
         ColumnDefinitionSegment result =
                 new ColumnDefinitionSegment(segment.getStartIndex(), segment.getStopIndex(), boundColumnSegment, segment.getDataType(), segment.isPrimaryKey(), segment.isNotNull(), segment.getText());
-        copy(segment, result);
+        copy(result, segment);
         segment.getReferencedTables().forEach(each -> result.getReferencedTables().add(SimpleTableSegmentBinder.bind(each, binderContext, tableBinderContexts)));
         return result;
     }