Remove useless MetaDataVersion.getActiveVersionKeys() (#31344)

apache · May 22, 2024 · 9e58dbc · 9e58dbc
1 parent 1a5c2cf
commit 9e58dbc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/...ommon/src/main/java/org/apache/shardingsphere/infra/metadata/version/MetaDataVersion.java b/...ommon/src/main/java/org/apache/shardingsphere/infra/metadata/version/MetaDataVersion.java
@@ -20,9 +20,6 @@
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 
-import java.util.Arrays;
-import java.util.Collection;
-
 /**
  * Meta data version.
  */
@@ -63,13 +60,4 @@ public String getActiveVersionNodePath() {
     public String getVersionsNodePath() {
         return String.join("/", key, VERSIONS, currentActiveVersion);
     }
-
-    /**
-     * Get active version keys.
-     *
-     * @return active version keys
-     */
-    public Collection<String> getActiveVersionKeys() {
-        return Arrays.asList(String.join("/", key, ACTIVE_VERSION), String.join("/", key, ACTIVE_VERSION, currentActiveVersion));
-    }
 }
diff --git a/...n/src/test/java/org/apache/shardingsphere/infra/metadata/version/MetaDataVersionTest.java b/...n/src/test/java/org/apache/shardingsphere/infra/metadata/version/MetaDataVersionTest.java
@@ -19,8 +19,6 @@
 
 import org.junit.jupiter.api.Test;
 
-import java.util.Arrays;
-
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 
@@ -35,9 +33,4 @@ void assertGetActiveVersionNodePath() {
     void assertGetVersionsNodePath() {
         assertThat(new MetaDataVersion("foo", "0", "1").getVersionsNodePath(), is("foo/versions/0"));
     }
-
-    @Test
-    void assertGetActiveVersionKeys() {
-        assertThat(new MetaDataVersion("foo", "0", "1").getActiveVersionKeys(), is(Arrays.asList("foo/active_version", "foo/active_version/0")));
-    }
 }
diff --git a/.../java/org/apache/shardingsphere/mode/manager/standalone/StandaloneModeContextManager.java b/.../java/org/apache/shardingsphere/mode/manager/standalone/StandaloneModeContextManager.java
@@ -282,10 +282,8 @@ private void sendDatabaseRuleChangedEvent(final String databaseName, final Colle
     }
 
     private void sendDatabaseRuleChangedEvent(final String databaseName, final MetaDataVersion metaDataVersion) {
-        for (String each : metaDataVersion.getActiveVersionKeys()) {
-            ruleConfigurationEventBuilder.build(databaseName, new DataChangedEvent(each, metaDataVersion.getNextActiveVersion(), Type.UPDATED))
-                    .ifPresent(optional -> contextManager.getComputeNodeInstanceContext().getEventBusContext().post(optional));
-        }
+        ruleConfigurationEventBuilder.build(databaseName, new DataChangedEvent(metaDataVersion.getActiveVersionNodePath(), metaDataVersion.getNextActiveVersion(), Type.UPDATED))
+                .ifPresent(optional -> contextManager.getComputeNodeInstanceContext().getEventBusContext().post(optional));
     }
 
     @Override