Remove useless codes

apache · May 25, 2024 · 8e959eb · 8e959eb
1 parent 321c5f6
commit 8e959eb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 19 deletions.
diff --git a/...rite/src/main/java/org/apache/shardingsphere/infra/rewrite/sql/token/pojo/Attachable.java b/...rite/src/main/java/org/apache/shardingsphere/infra/rewrite/sql/token/pojo/Attachable.java
@@ -21,11 +21,4 @@
  * Attach available.
  */
 public interface Attachable {
-
-    /**
-     * Get start index.
-     *
-     * @return start index
-     */
-    int getStartIndex();
 }
diff --git a/...pache/shardingsphere/sql/parser/sql/dialect/statement/doris/segment/ACLAttributeEnum.java b/...pache/shardingsphere/sql/parser/sql/dialect/statement/doris/segment/ACLAttributeEnum.java
@@ -19,5 +19,5 @@
 
 public enum ACLAttributeEnum {
 
-    UNCHANGED, DEFAULT, YES, NO
+    DEFAULT, YES, NO
 }
diff --git a/...pache/shardingsphere/sql/parser/sql/dialect/statement/mysql/segment/ACLAttributeEnum.java b/...pache/shardingsphere/sql/parser/sql/dialect/statement/mysql/segment/ACLAttributeEnum.java
@@ -19,5 +19,5 @@
 
 public enum ACLAttributeEnum {
 
-    UNCHANGED, DEFAULT, YES, NO
+    DEFAULT, YES, NO
 }
diff --git a/...shardingsphere/proxy/backend/handler/admin/executor/AbstractDatabaseMetaDataExecutor.java b/...shardingsphere/proxy/backend/handler/admin/executor/AbstractDatabaseMetaDataExecutor.java
@@ -70,7 +70,6 @@ public abstract class AbstractDatabaseMetaDataExecutor implements DatabaseAdminQ
     public final void execute(final ConnectionSession connectionSession) throws SQLException {
         Collection<String> databaseNames = getDatabaseNames(connectionSession);
         for (String databaseName : databaseNames) {
-            initDatabaseData(databaseName);
             processMetaData(databaseName, resultSet -> handleResultSet(databaseName, resultSet));
         }
         postProcess();
@@ -82,9 +81,10 @@ public final void execute(final ConnectionSession connectionSession) throws SQLE
     private void handleResultSet(final String databaseName, final ResultSet resultSet) {
         ResultSetMetaData metaData = resultSet.getMetaData();
         while (resultSet.next()) {
-            Map<String, Object> rowMap = new LinkedHashMap<>();
-            Map<String, String> aliasMap = new LinkedHashMap<>();
-            for (int i = 1; i < metaData.getColumnCount() + 1; i++) {
+            int columnCount = metaData.getColumnCount();
+            Map<String, Object> rowMap = new LinkedHashMap<>(columnCount, 1F);
+            Map<String, String> aliasMap = new LinkedHashMap<>(columnCount, 1F);
+            for (int i = 1; i < columnCount + 1; i++) {
                 aliasMap.put(metaData.getColumnName(i), metaData.getColumnLabel(i));
                 rowMap.put(metaData.getColumnLabel(i), resultSet.getString(i));
             }
@@ -100,8 +100,6 @@ private void handleResultSet(final String databaseName, final ResultSet resultSe
         }
     }
 
-    protected abstract void initDatabaseData(String databaseName);
-
     protected abstract Collection<String> getDatabaseNames(ConnectionSession connectionSession);
 
     protected abstract void preProcess(String databaseName, Map<String, Object> rows, Map<String, String> alias);
@@ -144,10 +142,6 @@ public static class DefaultDatabaseMetaDataExecutor extends AbstractDatabaseMeta
 
         private final List<Object> parameters;
 
-        @Override
-        protected void initDatabaseData(final String databaseName) {
-        }
-
         @Override
         protected Collection<String> getDatabaseNames(final ConnectionSession connectionSession) {
             Optional<String> database = ProxyContext.getInstance().getAllDatabaseNames().stream().filter(each -> isAuthorized(each, connectionSession.getGrantee()))