Skip to content

Commit

Permalink
Add : add check profile to validate the code
Browse files Browse the repository at this point in the history
  • Loading branch information
@taojintianxia
taojintianxia committed Sep 25, 2023
1 parent cbc0feb commit 54cd129
Show file tree
Hide file tree
Showing 3 changed files with 162 additions and 177 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/required-check.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Run CheckStyle
run: ./mvnw checkstyle:check -Dcheckstyle.skip=false -T1C
run: ./mvnw checkstyle:check -Dcheckstyle.skip=false -Pcheck -T1C

check-spotless:
if: ${{ needs.global-environment.outputs.GLOBAL_JOB_ENABLED == 'true' }}
Expand All @@ -51,7 +51,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Run Spotless
run: ./mvnw spotless:check -T1C
run: ./mvnw spotless:check -Pcheck -T1C

check-license:
if: ${{ needs.global-environment.outputs.GLOBAL_JOB_ENABLED == 'true' }}
Expand All @@ -62,4 +62,4 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Run Apache Rat
run: ./mvnw apache-rat:check -Drat.skip=false -T1C
run: ./mvnw apache-rat:check -Drat.skip=false -Pcheck -T1C
24 changes: 0 additions & 24 deletions .mvn/extensions.xml
View file

This file was deleted.

309 changes: 159 additions & 150 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -874,119 +874,6 @@
</configuration>
</plugin>

<!-- Check plugins -->
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
<configuration>
<!--suppress MavenModelInspection -->
<excludesFile>${maven.multiModuleProjectDirectory}/src/resources/rat.txt</excludesFile>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
<phase>verify</phase>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>${spotless-maven-plugin.version}</version>
<configuration>
<java>
<eclipse>
<!--suppress MavenModelInspection -->
<file>${maven.multiModuleProjectDirectory}/src/resources/spotless/java.xml</file>
</eclipse>
<licenseHeader>
<!--suppress MavenModelInspection -->
<file>${maven.multiModuleProjectDirectory}/src/resources/spotless/copyright.txt</file>
</licenseHeader>
</java>
<pom>
<sortPom>
<encoding>UTF-8</encoding>
<nrOfIndentSpace>4</nrOfIndentSpace>
<keepBlankLines>true</keepBlankLines>
<indentBlankLines>true</indentBlankLines>
<indentSchemaLocation>false</indentSchemaLocation>
<spaceBeforeCloseEmptyElement>true</spaceBeforeCloseEmptyElement>
<sortModules>false</sortModules>
<sortExecutions>false</sortExecutions>
<predefinedSortOrder>custom_1</predefinedSortOrder>
<expandEmptyElements>false</expandEmptyElements>
<sortProperties>false</sortProperties>
</sortPom>
<replace>
<name>Leading blank line</name>
<search>--&gt;
&lt;project</search>
<replacement>--&gt;

&lt;project</replacement>
</replace>
</pom>
</configuration>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
<configuration>
<consoleOutput>true</consoleOutput>
<failOnViolation>true</failOnViolation>
<failsOnError>true</failsOnError>
<violationSeverity>error</violationSeverity>
<!--suppress MavenModelInspection -->
<configLocation>${maven.multiModuleProjectDirectory}/src/resources/checkstyle.xml</configLocation>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>**/autogen/**/*</excludes>
</configuration>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
<version>${maven-pmd-plugin.version}</version>
<configuration>
<aggregate>true</aggregate>
<targetJdk>${java.version}</targetJdk>
<rulesets>
<!--suppress MavenModelInspection -->
<ruleset>${maven.multiModuleProjectDirectory}/src/resources/pmd.xml</ruleset>
</rulesets>
</configuration>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<configuration>
<fork>false</fork>
<failOnError>false</failOnError>
<!--suppress MavenModelInspection -->
<excludeFilterFile>${maven.multiModuleProjectDirectory}/src/resources/spotbugs.xml</excludeFilterFile>
<plugins>
<plugin>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
<version>${fb-contrib.version}</version>
</plugin>
<plugin>
<groupId>com.h3xstream.findsecbugs</groupId>
<artifactId>findsecbugs-plugin</artifactId>
<version>${findsecbugs.version}</version>
</plugin>
</plugins>
</configuration>
</plugin>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${sonar-maven-plugin.version}</version>
</plugin>

<!-- Report plugins -->
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
Expand Down Expand Up @@ -1044,43 +931,6 @@
</execution>
</executions>
</plugin>

<!-- Check plugins -->
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>apply</goal>
</goals>
<phase>compile</phase>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<id>validate</id>
<goals>
<goal>check</goal>
</goals>
<phase>validate</phase>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
</plugin>
</plugins>

<extensions>
Expand Down Expand Up @@ -1292,5 +1142,164 @@
</plugins>
</build>
</profile>
<profile>
<id>check</id>
<build>
<pluginManagement>
<plugins>
<!-- Check plugins -->
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
<configuration>
<!--suppress MavenModelInspection -->
<excludesFile>${maven.multiModuleProjectDirectory}/src/resources/rat.txt</excludesFile>
</configuration>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
<phase>verify</phase>
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>${spotless-maven-plugin.version}</version>
<configuration>
<java>
<eclipse>
<!--suppress MavenModelInspection -->
<file>${maven.multiModuleProjectDirectory}/src/resources/spotless/java.xml</file>
</eclipse>
<licenseHeader>
<!--suppress MavenModelInspection -->
<file>${maven.multiModuleProjectDirectory}/src/resources/spotless/copyright.txt</file>
</licenseHeader>
</java>
<pom>
<sortPom>
<encoding>UTF-8</encoding>
<nrOfIndentSpace>4</nrOfIndentSpace>
<keepBlankLines>true</keepBlankLines>
<indentBlankLines>true</indentBlankLines>
<indentSchemaLocation>false</indentSchemaLocation>
<spaceBeforeCloseEmptyElement>true</spaceBeforeCloseEmptyElement>
<sortModules>false</sortModules>
<sortExecutions>false</sortExecutions>
<predefinedSortOrder>custom_1</predefinedSortOrder>
<expandEmptyElements>false</expandEmptyElements>
<sortProperties>false</sortProperties>
</sortPom>
<replace>
<name>Leading blank line</name>
<search>--&gt;
&lt;project</search>
<replacement>--&gt;

&lt;project</replacement>
</replace>
</pom>
</configuration>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
<configuration>
<consoleOutput>true</consoleOutput>
<failOnViolation>true</failOnViolation>
<failsOnError>true</failsOnError>
<violationSeverity>error</violationSeverity>
<!--suppress MavenModelInspection -->
<configLocation>${maven.multiModuleProjectDirectory}/src/resources/checkstyle.xml</configLocation>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>**/autogen/**/*</excludes>
</configuration>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
<version>${maven-pmd-plugin.version}</version>
<configuration>
<aggregate>true</aggregate>
<targetJdk>${java.version}</targetJdk>
<rulesets>
<!--suppress MavenModelInspection -->
<ruleset>${maven.multiModuleProjectDirectory}/src/resources/pmd.xml</ruleset>
</rulesets>
</configuration>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<configuration>
<fork>false</fork>
<failOnError>false</failOnError>
<!--suppress MavenModelInspection -->
<excludeFilterFile>${maven.multiModuleProjectDirectory}/src/resources/spotbugs.xml</excludeFilterFile>
<plugins>
<plugin>
<groupId>com.mebigfatguy.fb-contrib</groupId>
<artifactId>fb-contrib</artifactId>
<version>${fb-contrib.version}</version>
</plugin>
<plugin>
<groupId>com.h3xstream.findsecbugs</groupId>
<artifactId>findsecbugs-plugin</artifactId>
<version>${findsecbugs.version}</version>
</plugin>
</plugins>
</configuration>
</plugin>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${sonar-maven-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<!-- Check plugins -->
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>apply</goal>
</goals>
<phase>compile</phase>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<id>validate</id>
<goals>
<goal>check</goal>
</goals>
<phase>validate</phase>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-pmd-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>

0 comments on commit 54cd129

Please sign in to comment.