Refactor ShowStorageUnitExecutor (#28689)

* Refactor ShowStorageUnitExecutor * Refactor ShowStorageUnitExecutor * Refactor SQLFederationRuleConfiguration
apache · Oct 8, 2023 · 1e2fe35 · 1e2fe35
1 parent 38405b2
commit 1e2fe35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...va/org/apache/shardingsphere/sqlfederation/api/config/SQLFederationRuleConfiguration.java b/...va/org/apache/shardingsphere/sqlfederation/api/config/SQLFederationRuleConfiguration.java
@@ -26,9 +26,9 @@
 /**
  * SQL federation rule configuration.
  */
+@RequiredArgsConstructor
 @Getter
 @Setter
-@RequiredArgsConstructor
 public final class SQLFederationRuleConfiguration implements GlobalRuleConfiguration {
 
     private final boolean sqlFederationEnabled;

diff --git a/...che/shardingsphere/sqlfederation/distsql/handler/query/ShowSQLFederationRuleExecutor.java b/...che/shardingsphere/sqlfederation/distsql/handler/query/ShowSQLFederationRuleExecutor.java
@@ -36,8 +36,10 @@ public final class ShowSQLFederationRuleExecutor implements MetaDataRequiredQuer
     @Override
     public Collection<LocalDataQueryResultRow> getRows(final ShardingSphereMetaData metaData, final ShowSQLFederationRuleStatement sqlStatement) {
         SQLFederationRuleConfiguration ruleConfig = metaData.getGlobalRuleMetaData().getSingleRule(SQLFederationRule.class).getConfiguration();
-        return Collections.singleton(new LocalDataQueryResultRow(String.valueOf(ruleConfig.isSqlFederationEnabled()),
-                null != ruleConfig.getExecutionPlanCache() ? ruleConfig.getExecutionPlanCache().toString() : ""));
+        String sqlFederationEnabled = String.valueOf(ruleConfig.isSqlFederationEnabled());
+        String executionPlanCache = null != ruleConfig.getExecutionPlanCache() ? ruleConfig.getExecutionPlanCache().toString() : "";
+        LocalDataQueryResultRow row = new LocalDataQueryResultRow(sqlFederationEnabled, executionPlanCache);
+        return Collections.singleton(row);
     }
 
     @Override