Upgrade logback version

apache · Oct 21, 2023 · 0ae438f · 0ae438f
1 parent 5003f4d
commit 0ae438f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...core/src/test/java/org/apache/shardingsphere/fixture/log/LogbackConfigurationFixture.java b/...core/src/test/java/org/apache/shardingsphere/fixture/log/LogbackConfigurationFixture.java
@@ -39,7 +39,7 @@ public final class LogbackConfigurationFixture extends BasicConfigurator {
     public static final String SHARDINGSPHERE_LOGGER_NAME = "org.apache.shardingsphere.agent";
 
     @Override
-    public void configure(final LoggerContext loggerContext) {
+    public ExecutionStatus configure(final LoggerContext loggerContext) {
         Appender<ILoggingEvent> appender = createFileAppender(loggerContext);
         Logger rootLogger = loggerContext.getLogger(Logger.ROOT_LOGGER_NAME);
         rootLogger.setLevel(Level.INFO);
@@ -48,6 +48,7 @@ public void configure(final LoggerContext loggerContext) {
         logger.setLevel(Level.INFO);
         logger.setAdditive(false);
         logger.addAppender(appender);
+        return ExecutionStatus.NEUTRAL;
     }
 
     private FileAppender<ILoggingEvent> createFileAppender(final LoggerContext loggerContext) {

diff --git a/pom.xml b/pom.xml
@@ -101,7 +101,7 @@
         <elasticjob.version>3.0.4</elasticjob.version>
 
         <slf4j.version>2.0.9</slf4j.version>
-        <logback.version>1.2.12</logback.version>
+        <logback.version>1.4.11</logback.version>
         <commons-logging.version>1.2</commons-logging.version>
 
         <lombok.version>1.18.30</lombok.version>

diff --git a/.../bootstrap/src/main/java/org/apache/shardingsphere/proxy/config/LogbackConfiguration.java b/.../bootstrap/src/main/java/org/apache/shardingsphere/proxy/config/LogbackConfiguration.java
@@ -39,12 +39,13 @@ public class LogbackConfiguration extends BasicConfigurator {
     public static final String NETTY_LOGGER_NAME = "io.netty";
 
     @Override
-    public void configure(final LoggerContext loggerContext) {
+    public ExecutionStatus configure(final LoggerContext loggerContext) {
         ConsoleAppender<ILoggingEvent> consoleAppender = createConsoleAppender(loggerContext);
         Logger rootLogger = loggerContext.getLogger(Logger.ROOT_LOGGER_NAME);
         rootLogger.setLevel(Level.INFO);
         rootLogger.addAppender(consoleAppender);
         initBasicLogger(loggerContext);
+        return ExecutionStatus.NEUTRAL;
     }
 
     private ConsoleAppender<ILoggingEvent> createConsoleAppender(final LoggerContext loggerContext) {