New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor polling detail #116

Merged

tianxiaoliang merged 1 commit into apache:master from tianxiaoliang:dev

Mar 14, 2020

Contributor

tianxiaoliang commented Mar 12, 2020 •

edited

Loading

代码坏味道，有3个方法有过多的入参
错误的uuid生成方式，不该每次都生成，只需要在创建时生成
domain在同表中两个字段都记录了，冗余了
使用handler这种优雅方式记录推送轨迹，功能剥离具体业务代码
不对domain为空进行错误返回，统一在handler里处理才对，到业务中默认就一定是有的

tianxiaoliang force-pushed the dev branch from 1663075 to 7ec8bbe Compare

March 12, 2020 13:25


          refactor polling detail

d22a41c

tianxiaoliang force-pushed the dev branch from 7ec8bbe to d22a41c Compare

March 13, 2020 03:08

tianxiaoliang merged commit 758438e into apache:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet