Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Revert upgrade presto-0.287 #37

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

xiangyuf
Copy link
Contributor

To close the issue: #36

@xiangyuf
Copy link
Contributor Author

@JingsongLi @lanvendar pls review this when you have time.

@lanvendar
Copy link
Contributor

lanvendar commented Jul 30, 2024

pls compile without test code,like this
mvn clean install -DskipTests -am -pl paimon-presto-0.287 -Dpresto.version=0.287 -Dhadoop.apache2.version=2.7.4-12 -Dhive.apache.version=3.0.0-10

@JingsongLi @lanvendar pls review this when you have time.

@xiangyuf
Copy link
Contributor Author

pls compile without test code,like this mvn clean install -DskipTests -am -pl paimon-presto-0.287 -Dpresto.version=0.287 -Dhadoop.apache2.version=2.7.4-12 -Dhive.apache.version=3.0.0-10

@JingsongLi @lanvendar pls review this when you have time.

Still error.
image

After revert 0.287, the compilation could success.
image

@xiangyuf
Copy link
Contributor Author

@JingsongLi @lanvendar Hi, in my humble opinion, we should revert the 0.287 upgrade first and introduce this later at least until it compiles.

@lanvendar
Copy link
Contributor

lanvendar commented Aug 19, 2024

@JingsongLi @lanvendar Hi, in my humble opinion, we should revert the 0.287 upgrade first and introduce this later at least until it compiles.

@xiangyuf The testing bug has been fixed. Please refer to my fork personal repository for details. I will apply for a merge later
image

@xiangyuf
Copy link
Contributor Author

@JingsongLi @lanvendar Hi, in my humble opinion, we should revert the 0.287 upgrade first and introduce this later at least until it compiles.

@xiangyuf The testing bug has been fixed. Please refer to my fork personal repository for details. I will apply for a merge later image

@lanvendar Looking forward for your MR.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 9f4e6ed into apache:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants