Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11632. Publish images to GitHub container repo #9

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

ozone-testkrb5 workflow similar to the one for ozone-runner: publish multi-platform image to GitHub Container Registry.

Since this is an unsecure KDC only for testing, I propose to publish future updates only to GitHub Container Registry. Existing image in Docker Hub needs to be retained for use by older Ozone versions.

https://issues.apache.org/jira/browse/HDDS-11632

How was this patch tested?

Workflow runs:

Verified the image published by executing a subset of ozonesecure tests.

diff --git hadoop-ozone/dist/pom.xml hadoop-ozone/dist/pom.xml
index b0fd526b80..ca01956939 100644
--- hadoop-ozone/dist/pom.xml
+++ hadoop-ozone/dist/pom.xml
@@ -29,7 +29,7 @@
     <file.encoding>UTF-8</file.encoding>
     <downloadSources>true</downloadSources>
     <docker.ozone-runner.version>20241104-jdk17-1</docker.ozone-runner.version>
-    <docker.ozone-testkr5b.image>apache/ozone-testkrb5:20230318-1</docker.ozone-testkr5b.image>
+    <docker.ozone-testkr5b.image>ghcr.io/adoroszlai/ozone-testkrb5:test-HDDS-11632</docker.ozone-testkr5b.image>
     <maven.test.skip>true</maven.test.skip> <!-- no tests in this module so far -->
   </properties>
 
$ hadoop-ozone/dist/src/main/keytabs/update-keytabs.sh
...
$ mvn -DskipTests -DskipShade clean package
$ cd hadoop-ozone/dist/target/ozone-2.0.0-SNAPSHOT/compose/ozonesecure
# edit test.sh, remove most tests
$ ./test.sh
...
Kinit :: Kinit test user                                              | PASS |
1 test, 1 passed, 0 failed
...
Basic Freon smoketest                                                 | PASS |
...
2 tests, 2 passed, 0 failed

@adoroszlai adoroszlai self-assigned this Nov 7, 2024
Copy link

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @adoroszlai .

pls feel free to merge this when infra issue is resolved.

@adoroszlai
Copy link
Contributor Author

pls feel free to merge this when infra issue is resolved.

This one is not affected by the infra issue, since the proposed change does not publish to Docker Hub.

@adoroszlai adoroszlai merged commit a4ba3ab into apache:master Nov 12, 2024
1 check passed
@adoroszlai adoroszlai deleted the HDDS-11632 branch November 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants