Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-5556: Write Returns Metadata #5556

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

Part of #5544.

Rationale for this change

What changes are included in this PR?

A new RFC

Are there any user-facing changes?

None

@meteorgan meteorgan changed the title RFC: Write Returns Metadata RFC-5556: Write Returns Metadata Jan 16, 2025
@meteorgan
Copy link
Contributor Author

Most of the checks shouldn't be triggered here.

@meteorgan meteorgan marked this pull request as ready for review January 16, 2025 10:33
@meteorgan meteorgan requested a review from Xuanwo as a code owner January 16, 2025 10:33
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for working on this, really great!

core/src/docs/rfcs/5556_write_returns_metadata.md Outdated Show resolved Hide resolved
core/src/docs/rfcs/5556_write_returns_metadata.md Outdated Show resolved Hide resolved
@meteorgan meteorgan force-pushed the rfc_return_metadata_after_writing branch from fd5e35e to 80a5b2f Compare January 16, 2025 14:42
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for working on this, I beileve this will be a great feature

@Xuanwo Xuanwo merged commit da155ee into apache:main Jan 16, 2025
84 checks passed
@meteorgan meteorgan deleted the rfc_return_metadata_after_writing branch January 16, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants