Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement if_modified_since and if_unmodified_since for stat_with #5528

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(core): implement if_modified_since and if_unmodified_since for stat_with #5528

merged 1 commit into from
Jan 9, 2025
+158 −3

Conversation

meteorgan
Copy link
Contributor

Which issue does this PR close?

None

Rationale for this change

support conditional stat based on modification time.

What changes are included in this PR?

Are there any user-facing changes?

Yes. we can use stat_with().if_modified_since() and stat().if_unmodified_since() now.

@meteorgan meteorgan marked this pull request as ready for review January 9, 2025 14:19
@meteorgan meteorgan requested a review from Xuanwo as a code owner January 9, 2025 14:19
Xuanwo
Xuanwo approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @meteorgan for working on this—truly impressive.

@Xuanwo Xuanwo merged commit 86ba75d into apache:main Jan 9, 2025
241 checks passed
@meteorgan meteorgan deleted the stat_options branch January 9, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorgan @Xuanwo