-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Implement list with deleted for s3 service #5498
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
CodSpeed Performance ReportMerging #5498 will improve performances by 18.88%Comparing Summary
Benchmarks breakdown
|
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
if let Some(etag) = version_object.etag { | ||
meta.set_etag(&etag); | ||
meta.set_content_md5(etag.trim_matches('"')); | ||
if self.args.deleted() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I misunderstand something ? this implementation seems to differ from the RFC description:
Please note that `deleted` here means "including deleted files" rather than "only deleted files." Therefore, `list_with(path).deleted(true)` will list both current files and deleted ones. |
Which issue does this PR close?
Part of #5496
Rationale for this change
Implement the RFC we need.
What changes are included in this PR?
s3
servicesAre there any user-facing changes?
Users can now list deleted files from s3 services.