Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial Operator::from_uri implementation #5482

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open
273 changes: 266 additions & 7 deletions core/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ reqwest = { version = "0.12.2", features = [
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tokio = { version = "1.27", features = ["sync", "io-util"] }
# TODO: I added this dependency in order to not re-implement the Url::query_pairs function.
# Is it okay to include it? (we are using that crate in the ofs binary https://github.com/apache/opendal/blob/main/bin/ofs/Cargo.toml#L45
url = "2.5.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use http::uri instead. During the development of core, there is no need to reference other download stream projects. Simply make the best decision based on the current core code.

uuid = { version = "1", features = ["serde", "v4"] }

# Test only dependencies
Expand Down
Loading
Loading