dev: parse deprecated note from config and make bool optional #5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
requested review from
messense,
Zheaoli,
Xuanwo and
PsiACE
as code owners
trim21
force-pushed
the
gen-deprecated
branch
from
030c076 to
e04e41f
Compare
trim21
force-pushed
the
gen-deprecated
branch
2 times, most recently
from
a0f4b35 to
87f8944
Compare
trim21
force-pushed
the
gen-deprecated
branch
5 times, most recently
from
d1f36fc to
d669f61
Compare
trim21
changed the title
trim21
force-pushed
the
gen-deprecated
branch
6 times, most recently
from
4315bb1 to
48d8592
Compare
trim21
force-pushed
the
gen-deprecated
branch
from
48d8592 to
7413f02
Compare
Xuanwo
reviewed
Dec 27, 2024
trim21
force-pushed
the
gen-deprecated
branch
3 times, most recently
from
99ab8f0 to
ddd08e1
Compare
Signed-off-by: Xuanwo <[email protected]>
trim21
force-pushed
the
gen-deprecated
branch
from
ddd08e1 to
fb3c2c3
Compare
Xuanwo
force-pushed
the
gen-deprecated
branch
from
fb3c2c3 to
82526bf
Compare
|
Hi, @trim21, sorry for force-pushing my changes. I find it much easier to do this rather than trying to resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
#[deprecated(...)]field attrubite from Config.Are there any user-facing changes?
no